Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exception-group): Display related exceptions in UI #47176

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Apr 11, 2023

Closes #47085

CleanShot 2023-04-11 at 13 30 14

@malwilley malwilley requested a review from a team April 11, 2023 20:36
@malwilley malwilley requested a review from a team as a code owner April 11, 2023 20:36
@malwilley malwilley removed the request for review from a team April 11, 2023 20:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 11, 2023
@malwilley malwilley marked this pull request as draft April 14, 2023 16:54
@mattjohnsonpint
Copy link
Contributor

Looking good so far, thanks! We'll have to wait until https://github.com/getsentry/team-ingest/issues/102 is complete, or at least until getsentry/relay#2020 is deployed. It's already merged and staged for next release of Relay. You could set up a local Relay instance to test with in the meantime, if that would be helpful. But I think it will be easier to collaborate on UI changes when it's deployed to sentry.io.

@malwilley malwilley force-pushed the malwilley/feat/exceptiongroup-fe branch from ea30cb2 to a2b03d9 Compare April 19, 2023 16:33
@malwilley malwilley marked this pull request as ready for review April 19, 2023 19:47
@malwilley
Copy link
Member Author

@priscilawebdev since you have the most experience with the stacktrace components could I bother you for a review?

There is a .NET issue in the sentry-sdks org you can test with here

@priscilawebdev
Copy link
Member

do we want to merge this PR that is not behind a feature flag even if the task is not completed yet?

@priscilawebdev
Copy link
Member

image
should we add a description next to the links so users can know which exception group it belongs to?

Example:

- System.AggregateException
   . System.Exception - Test 1
   . System.Exception - Test 2

@priscilawebdev
Copy link
Member

Screenshot 2023-04-21 at 11 12 31

when jumping to a group of exceptions, shall the frames be expanded by default?

@priscilawebdev
Copy link
Member

image
I am confused by this, since the first exception matches the description but it is not collapsed by default

@priscilawebdev
Copy link
Member

will this new change also be applied to threads? it would be nice to have a few examples

@priscilawebdev
Copy link
Member

nit: noticed that we don't have a spacing between the description and the tag on smaller devices. can we please add some?
image

@priscilawebdev
Copy link
Member

tested the example exception and many others (nextjs, javascript, python, flask) and the UI looks good to me. will only wait for a few answers to my questions before approving 😉

@malwilley
Copy link
Member Author

Thank you for the thorough review @priscilawebdev! I've pushed commits that should address all your comments, and answered your questions below:

do we want to merge this PR that is not behind a feature flag even if the https://github.com/getsentry/team-ingest/issues/102 is not completed yet?

There shouldn't be any risk to merging this without a feature flag since this will only apply to issues with exception groups.

should we add a description next to the links so users can know which exception group it belongs to?

Yes! Added here: a13209e

am confused by this, since the first exception matches the description but it is not collapsed by default

Ah yes, collapsing child exception groups will be done in a followup ticket

will this new change also be applied to threads? it would be nice to have a few examples

Exception groups are only implemented for the Exception interface, so this won't be a feature of threads (for now).

nit: noticed that we don't have a spacing between the description and the tag on smaller devices. can we please add some?

Good catch, I'll fix that in another PR since that shouldn't be related to these changes

Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@malwilley malwilley merged commit 0aaef53 into master Apr 25, 2023
@malwilley malwilley deleted the malwilley/feat/exceptiongroup-fe branch April 25, 2023 17:13
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement exception groups in the UI
3 participants