-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exception-group): Display related exceptions in UI #47176
Conversation
Looking good so far, thanks! We'll have to wait until https://github.com/getsentry/team-ingest/issues/102 is complete, or at least until getsentry/relay#2020 is deployed. It's already merged and staged for next release of Relay. You could set up a local Relay instance to test with in the meantime, if that would be helpful. But I think it will be easier to collaborate on UI changes when it's deployed to sentry.io. |
ea02b4e
to
ea30cb2
Compare
ea30cb2
to
a2b03d9
Compare
@priscilawebdev since you have the most experience with the stacktrace components could I bother you for a review? There is a .NET issue in the sentry-sdks org you can test with here |
static/app/components/events/interfaces/frame/exceptionGroupContext.tsx
Outdated
Show resolved
Hide resolved
do we want to merge this PR that is not behind a feature flag even if the task is not completed yet? |
will this new change also be applied to threads? it would be nice to have a few examples |
tested the example exception and many others (nextjs, javascript, python, flask) and the UI looks good to me. will only wait for a few answers to my questions before approving 😉 |
Thank you for the thorough review @priscilawebdev! I've pushed commits that should address all your comments, and answered your questions below:
There shouldn't be any risk to merging this without a feature flag since this will only apply to issues with exception groups.
Yes! Added here: a13209e
Ah yes, collapsing child exception groups will be done in a followup ticket
Exception groups are only implemented for the Exception interface, so this won't be a feature of threads (for now).
Good catch, I'll fix that in another PR since that shouldn't be related to these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #47085