Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception Groups: Collapse child exception groups by default #47828

Closed
malwilley opened this issue Apr 24, 2023 · 0 comments · Fixed by #48527
Closed

Exception Groups: Collapse child exception groups by default #47828

malwilley opened this issue Apr 24, 2023 · 0 comments · Fixed by #48527
Assignees
@malwilley

Comments

@malwilley
Copy link
Member

malwilley commented Apr 24, 2023 •
edited
Loading

Instead of rendering the full tree of exceptions, we want to collapse any child exception groups to ensure that the stack trace section doesn't get too long.

Note that clicking links to other exceptions in the group should automatically expand it.

See Figma (internal link) for designs.

Image
@malwilley malwilley self-assigned this Apr 24, 2023
@malwilley malwilley mentioned this issue Apr 24, 2023
Merged
@malwilley malwilley mentioned this issue May 4, 2023
Merged
mattjohnsonpint pushed a commit that referenced this issue May 5, 2023
@malwilley
feat(exception-group): Auto-collapse child exception groups (#48527)
9ec1fca 
Closes #47828

To prevent the stack trace from becoming too long and unwieldy, this
collapses child exception groups. This means that only the first level
of the tree is visible at first, but the user may expand them by
clicking "Show n related exceptions" or clicking the element in the
exception tree.

Can test on this issue:
https://sentry-sdks.dev.getsentry.net:7999/issues/4126628864/events/e303031f97ab4b25b0f275d41a35a323/?project=5428537



https://user-images.githubusercontent.com/10888943/236264285-819e2ba8-a89d-4466-beac-a6961c1cb4e3.mp4
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@malwilley malwilley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(exception-group): Auto-collapse child exception groups getsentry/sentry
1 participant
@malwilley