Fix Wikipedia link #9429
Closed
Fix Wikipedia link #9429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end of the Wikipedia link has a parenthesis, which was incorrectly used as end of markdown format for link.
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @mtunique to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
facebook-github-bot
added
the
CLA Signed
ghost
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2016
Summary: The markdown parser (Marked) used by the docs doesn't handle links ending with a closing bracket. The result is a broken link in the [Integration With Existing Apps](http://facebook.github.io/react-native/docs/integration-with-existing-apps.html#our-sample-app) guide. Using HTML makes the parser ignoring these links. Note: this is a well-known issue of Marked: markedjs/marked#690 Note bis: The fix #9429 didn't solve the problem. Closes #10225 Differential Revision: D3964341 fbshipit-source-id: 61564d1cbb632fa1f0c71e7c6cbdc0b9a200caa4
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end of the Wikipedia link has a parenthesis, which was incorrectly used as end of markdown format for link.