[Docs] Use HTML for links including closing bracket #10225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown parser (Marked) used by the docs doesn't handle links ending with a closing bracket. Using HTML makes the parser ignoring these links.
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @jankalfus to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown parser (Marked) used by the docs doesn't handle links ending with a closing bracket. The result is a broken link in the Integration With Existing Apps guide.
Using HTML makes the parser ignoring these links.
Note: this is a well-known issue of Marked: markedjs/marked#690
Note bis: The fix #9429 didn't solve the problem.