Bump devcontainer version to 1.24 #19582
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327, ivanvc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19582 +/- ##
==========================================
- Coverage 68.91% 68.80% -0.11%
==========================================
Files 421 421
Lines 35900 35900
==========================================
- Hits 24739 24700 -39
- Misses 9740 9771 +31
- Partials 1421 1429 +8 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@ivanvc for some reason, according to the available image tags here, they only offer the I have tested the changes on GitHub codespaces (as this is my main development environment now) which works for now, but we might need to keep an eye out for the images tag when it's updated. |
According to the available image tag list [2], the images for go 1.24 are all prefixed with `dev-`. Thus, we are using the `dev-` prefixed image version for now. Reference: [1] etcd-io#19524 [2] https://mcr.microsoft.com/v2/devcontainers/go/tags/list Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
ci/update-devcontainer-1.24
branch
from
a87a167 to
5eca42b
Compare
I think this is the last missing piece in #19440 :)
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.