Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.24.1 / 1.23.7 #19524

Closed
17 tasks done
ivanvc opened this issue Mar 4, 2025 · 10 comments
Closed
17 tasks done

Bump Go to 1.24.1 / 1.23.7 #19524

ivanvc opened this issue Mar 4, 2025 · 10 comments
Assignees
@ivanvc @moshevayner
Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Mar 4, 2025 •
edited
Loading

What would you like to be added?

Golang 1.24.1 and 1.23.7 were released today. According to our Dependency management documentation, we want to stay on the latest patch version. This means updating the release-3.4, release-3.5 and release-3.6 branches to 1.23.7 and main to 1.24.1.

This patch includes the security fix for CVE-2025-22870.

Progress track:

Please look at the previous issues and their pull requests, e.g., #19333 and #19210.

Why is this needed?

To keep the project up to date with the latest Go versions. And to address CVE-2025-22870.
@ivanvc ivanvc added area/security good first issue help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature labels Mar 4, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Mar 4, 2025 •
edited
Loading

I'll do etcd-io/etcd's. The rest are up for grabs.

/assign

This was referenced Mar 5, 2025
Closed
Merged
Merged
@moshevayner
Copy link
Member

@ivanvc I'll take the etcd-operator one! (cc @ahrtr )

@moshevayner moshevayner mentioned this issue Mar 5, 2025
Closed
@ivanvc
Copy link
Member Author

ivanvc commented Mar 5, 2025

/assign @moshevayner (etcd-operator)

@ivanvc ivanvc mentioned this issue Mar 5, 2025
Merged
@tcchawla
Copy link
Contributor

tcchawla commented Mar 5, 2025

Hey @ivanvc, I can work on the bbolt

cc @ahrtr

@MrDXY
Copy link

MrDXY commented Mar 5, 2025 •
edited
Loading

Hi @ivanvc , I’m happy to help with the raft part!

This was referenced Mar 5, 2025
Merged
Merged
@ivanvc
Copy link
Member Author

ivanvc commented Mar 5, 2025

Thanks, @MrDXY!

Thanks, @tcchawla. Note that we already have a pull request for main, as we haven't been able to bump Go to 1.24. But, you can do the release-1.3 and release-1.4 branches.

@shreekara-rajendra
Copy link

shreekara-rajendra commented Mar 6, 2025 •
edited
Loading

Hi @ivanvc , I can take up etcd-io/auger.

cc @ahrtr

@shreekara-rajendra shreekara-rajendra mentioned this issue Mar 6, 2025
Merged
@shreekara-rajendra
Copy link

@ivanvc, I can take on the remaining two as well.

cc @ahrtr

@ivanvc
Copy link
Member Author

ivanvc commented Mar 6, 2025

@ivanvc, I can take on the remaining two as well.

cc @ahrtr

Sure, go for it.

This was referenced Mar 7, 2025
Merged
Merged
@moshevayner moshevayner mentioned this issue Mar 8, 2025
Merged
@tcchawla tcchawla mentioned this issue Mar 9, 2025
Merged
@tcchawla tcchawla mentioned this issue Mar 9, 2025
Merged
@ivanvc ivanvc mentioned this issue Mar 11, 2025
Merged
@ivanvc
Copy link
Member Author

ivanvc commented Mar 12, 2025

I'm closing with all the tasks completed. Thanks to everyone who helped with this: @tcchawla, @moshevayner, @shreekara-rajendra, @MrDXY, and @Elbehery.

@ivanvc ivanvc closed this as completed Mar 12, 2025
henrybear327 pushed a commit to henrybear327/etcd that referenced this issue Mar 12, 2025
Bump devcontainer version to 1.24
a87a167 
Reference:
- etcd-io#19524

Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 mentioned this issue Mar 12, 2025
Open
henrybear327 pushed a commit to henrybear327/etcd that referenced this issue Mar 12, 2025
Bump devcontainer version to 1.24
5eca42b 
According to the available image tag list [2],
the images for go 1.24 are all prefixed with
`dev-`. Thus, we are using the `dev-` prefixed
image version for now.

Reference:
[1] etcd-io#19524
[2] https://mcr.microsoft.com/v2/devcontainers/go/tags/list

Signed-off-by: Chun-Hung Tseng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanvc ivanvc

@moshevayner moshevayner

Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ivanvc @moshevayner @MrDXY @tcchawla @shreekara-rajendra