-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go 1.24.0 #907
Bump go 1.24.0 #907
Conversation
@Elbehery, please update the golangci-lint version to 1.64.5. As I mentioned it in etcd-io/raft#268 (comment) |
1d1ef49
to
9d81a48
Compare
raised #916 to fix windows linter |
9d81a48
to
a04120f
Compare
/retest-required |
@Elbehery, it looks like the tests are hanging and timing out in Prow. I noticed that the previous jobs were killed after 48 hours. Can you run them locally and check if they're not finishing? It's weird because they have a |
/retest |
a04120f
to
8a6b543
Compare
@ivanvc I ran locally
and it passes 👍🏽 I suggest to bump the timeout, because the wdyt @ahrtr about bumping the timeout ? |
/retest |
8a6b543
to
ff1a2dd
Compare
@ivanvc I don't know how to fix this 🤔 any suggestions ? |
Increasing the timeout, I don't think, will make any difference, as it clearly is not terminating after the current set timeout. I would start troubleshooting by debugging the script in the Prow infrastructure. You can add a set If you feel this is something beyond what you could do, we can reassign this version upgrade to me, and I'll take a look at it later. |
I will continue but mid week, hope it is fine 👍🏽 |
That sounds good. Can you draft the pull request to avoid generating the never-ending prow jobs? We can manually trigger the tests for draft pull requests. I'll also open a PR in test-infra to add a timeout to the jobs. |
The kubekins image is now running Go 1.24. I'll retry a job to see if it still hangs. /test pull-bbolt-test-1-cpu-arm64 |
@Elbehery, could you please rebase this pull request? I removed the Prow jobs, which should unblock this PR. Thanks |
will do it now, so sorry for the delay |
ff1a2dd
to
64bd273
Compare
Signed-off-by: Mustafa Elbehery <[email protected]>
64bd273
to
24c5a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Elbehery!
@@ -1 +1 @@ | |||
1.23.6 | |||
1.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.24.1 is out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, good catch. @Elbehery, can you open a new pull request to bump Go to 1.24.1? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 👍🏽 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised #925
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, Elbehery, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref etcd-io/etcd#19417
cc @ivanvc @henrybear327