Remove Dockerfile.release and other docker related changes. #13999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable multi-stage builds for all our docker cases.
…from the command line
lystopad
requested review from
somnathb1,
antonis19,
yperbasis,
AskAlexSharov and
michelemodolo
|
It looks alright. I haven't dug down into specifics, but the built image is fine see: |
somnathb1
approved these changes
Feb 28, 2025
antonis19
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
User now can build docker image
local-erigon/erigon:latestusing:or define binaries and db-tools, using env variables:
@somnathb1 I would like to have your explicit approve for this PR.