-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dockerfile.release #7893
Comments
This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days. |
This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
I finalized changes and created PR here #13999 . Before merging I need feedback and approve mostly from @somnathb1 in order to minimize impact to his work with hive/docker. PR13999 could be merged once Som approved. |
Reason: 1 dockerfile is enough and now Dockerfile.release has only
erigon
binary (reason of #7847 ).goreleaser.yml
replace Dockerfile.release with just Dockerfile.goreleaser.yml
somehow need build ALL binaries (not onlyerigon
) - maybe we can't implement it by some kind ofwildcard
? It's ok that 1 docker image has all binaries - user still can run them as separated containers (same as our docker-compose.yml does)docker compose up -d
worksmake release-dry-run
andmake release
worksCI
actionRelease
works. Here is how to run it manually:Other things:
8. up golang version in Dockerifle.debian
9. check that Dockerfile.debian and Dockerfile match each other (have same binaries or features)
The text was updated successfully, but these errors were encountered: