Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile.release #7893

Open
AskAlexSharov opened this issue Jul 14, 2023 · 4 comments
Open

Remove Dockerfile.release #7893

AskAlexSharov opened this issue Jul 14, 2023 · 4 comments
Assignees

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Jul 14, 2023

Reason: 1 dockerfile is enough and now Dockerfile.release has only erigon binary (reason of #7847 )

  1. remove Dockerfile.release - use only Dockerfile
  2. in .goreleaser.yml replace Dockerfile.release with just Dockerfile
  3. in .goreleaser.yml somehow need build ALL binaries (not only erigon) - maybe we can't implement it by some kind of wildcard? It's ok that 1 docker image has all binaries - user still can run them as separated containers (same as our docker-compose.yml does)
  4. test that docker compose up -d works
  5. test that make release-dry-run and make release works
  6. test that CI action Release works. Here is how to run it manually:
Screenshot 2023-07-14 at 10 43 01

Other things:
8. up golang version in Dockerifle.debian
9. check that Dockerfile.debian and Dockerfile match each other (have same binaries or features)

@github-actions
Copy link

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 4, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@lystopad
Copy link
Member

lystopad commented Feb 27, 2025

I finalized changes and created PR here #13999 .

Before merging I need feedback and approve mostly from @somnathb1 in order to minimize impact to his work with hive/docker.

PR13999 could be merged once Som approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants