Portability workaround for wasi/api.h errno constants #10025
Merged
+94
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Dec 12, 2019
kripken
reviewed
Dec 12, 2019
Uses UINT16_C for backing of errno constants (EPERM etc) as in
previous versions, rather than casting them to __wasm_errno_t.
This fixes some portable codebases that use the C preprocessor
to compare the constant values like this:
```
#if EPERM > 0
#define DAV1D_ERR(e) (-(e))
#else
#define DAV1D_ERR(e) (e)
#endif
```
Adds a test case to catch regressions.
Fixes emscripten-core#9996
|
@juj does this address the issue you were seeing? |
|
Oh perfect, thanks! Missed this one go by.. |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…e#10025) Uses UINT16_C for backing of errno constants (EPERM etc) as in previous versions, rather than casting them to __wasm_errno_t. This fixes some portable codebases that use the C preprocessor to compare the constant values like this: ``` #if EPERM > 0 #define DAV1D_ERR(e) (-(e)) #else #define DAV1D_ERR(e) (e) #endif ``` Adds a test case to catch regressions. Fixes emscripten-core#9996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses UINT16_C for backing of errno constants (EPERM etc) as in
previous versions, rather than casting them to __wasm_errno_t.
This fixes some portable codebases that use the C preprocessor
to compare the constant values like this:
Adds a test case to catch regressions.
Fixes #9996