Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errno constants are no longer usable in pre-processor macros #146

Closed
sbc100 opened this issue Dec 13, 2019 · 0 comments · Fixed by #148
Closed

errno constants are no longer usable in pre-processor macros #146

sbc100 opened this issue Dec 13, 2019 · 0 comments · Fixed by #148

Comments

@sbc100
Copy link
Member

sbc100 commented Dec 13, 2019

We had this reported by a couple of different users independently in emscripten:
emscripten-core/emscripten#9996

Our downstream fix was:
emscripten-core/emscripten#10025
@pchickey pchickey mentioned this issue Dec 13, 2019
Closed
sunfishcode added a commit that referenced this issue Dec 13, 2019
@sunfishcode
Avoid using cast expressions in WASI API constants.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
545f25f 
Cast expressions aren't valid to use in some preprocessor constants, so
change the constants to use `UINT32_C` etc. instead of casts.

Fixes #146.
@sunfishcode sunfishcode mentioned this issue Dec 13, 2019
Merged
sunfishcode added a commit that referenced this issue Dec 13, 2019
@sunfishcode
Avoid using cast expressions in WASI API constants.
bb296f1 
Cast expressions aren't valid to use in some preprocessor constants, so
change the constants to use `UINT32_C` etc. instead of casts.

Fixes #146.
sunfishcode added a commit that referenced this issue Dec 16, 2019
@sunfishcode
Avoid using cast expressions in WASI API constants. (#148)
dd010be 
Cast expressions aren't valid to use in some preprocessor constants, so
change the constants to use `UINT32_C` etc. instead of casts.

Fixes #146.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using cast expressions in WASI API constants. WebAssembly/wasi-libc
1 participant
@sbc100