Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up to 16 shutters in discovery #226

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

lewurm
Copy link
Contributor

@lewurm lewurm commented May 19, 2023

Tasmota added support for more shutters recently: arendst/Tasmota#18295

The maximum number of shutters supported are now 16 shutters on newer hardware (i.e. ESP32).

Tasmota added support for more shutters recently: arendst/Tasmota#18295

The maximum number of shutters supported are now 16 shutters on newer hardware (i.e. ESP32).
@lewurm
Copy link
Contributor Author

lewurm commented May 19, 2023

FYI @stefanbode, this fixes HAAS discovery when xdrv_12_discovery is used with USE_SHUTTER_ESP32 enabled.

@stefanbode
Copy link
Contributor

Fine for me either

@lewurm
Copy link
Contributor Author

lewurm commented May 25, 2023

Hello @emontnemery, could you have a look at this PR? 🙂

@stefanbode
Copy link
Contributor

The number of shutters incoming can easily dynamically discovered through the discovery message. There is also recently the tilt added as also supported by MATTER.

@emontnemery
Copy link
Owner

@lewurm could you share a discovery message from a Tasmota device with more than 4 shutters (for example 16)?
@stefanbode Tilt has been supported for a long time: home-assistant/core#71789, did Tasmota add tilt support in some other way?

@stefanbode
Copy link
Contributor

The message just have more then 4 entries for shutters. The rest is the same. I do not know if tilt is in any of the ui enhancements. Never tried it out. The tilt is shown as entity.

@stefanbode
Copy link
Contributor

The tilt is in HA a subset of the shutterposition. Not easy to find but it is there. Pls see some images above

@emontnemery
Copy link
Owner

The tilt is in HA a subset of the shutterposition. Not easy to find but it is there. Pls see some images above

Which images?

@emontnemery emontnemery merged commit e780f94 into emontnemery:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants