Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tilt support to Tasmota covers #71789

Merged
merged 2 commits into from
May 13, 2022
Merged

Add tilt support to Tasmota covers #71789

merged 2 commits into from
May 13, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented May 13, 2022

Proposed change

Add tilt support to Tasmota shutters
Note: This also needs arendst/Tasmota#15612 which is included in Tasmota v 12.0.0, and daily dev builds starting from 2022-05-14

Bump hatasmota from 0.4.1 to 0.5.0

Changes:

Git compare: https://github.com/emontnemery/hatasmota/compare/0.4.1..0.5.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode merged commit 08ee276 into dev May 13, 2022
@thecode thecode deleted the tasmota_cover_tilt branch May 13, 2022 19:03
@tsrubar
Copy link

tsrubar commented May 14, 2022

Just recreated HA container with latest dev image (Home Assistant Core 2022.6.0.dev20220514), deleted device, restarted device, it reappeared in HA with Tasmota 11.1.0.3, but no joy yet :(
image
Including discovery messages:
config:
{"ip":"192.168.83.201","dn":"Zaluzie-spalna","fn":["Tasmota","",null,null,null,null,null,null],"hn":"tasmota-0CFC20-7200","mac":"E0E2E60CFC20","md":"Sonoff Dual R3 v2","ty":0,"if":0,"ofln":"Offline","onln":"Online","state":["OFF","ON","TOGGLE","HOLD"],"sw":"11.1.0.3","t":"tasmota_0CFC20","ft":"%prefix%/%topic%/","tp":["cmnd","stat","tele"],"rl":[3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"swc":[-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1],"swn":[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null],"btn":[0,0,0,0,0,0,0,0],"so":{"4":0,"11":0,"13":0,"17":0,"20":0,"30":0,"68":0,"73":0,"82":0,"114":0,"117":0},"lk":0,"lt_st":0,"sho":[0,0,0,0],"sht":[[-90,0,24],[0,0,0],[0,0,0],[0,0,0]],"ver":1}
sensors:
{"sn":{"Time":"2022-05-14T18:33:30","ENERGY":{"TotalStartTime":"2022-01-14T11:06:27","Total":0.259,"Yesterday":0.000,"Today":0.002,"Power":[ 0, 0],"ApparentPower":[ 0, 0],"ReactivePower":[ 0, 0],"Factor":[0.00,0.00],"Voltage": 0,"Current":[0.000,0.000],"BL09XX":{"Temperature":31.7}},"ESP32":{"Temperature":48.3},"Shutter1":{"Position":100,"Direction":0,"Target":100,"Tilt":0},"TempUnit":"C"},"ver":1}

To be exact. Manually calling service cover.toggle_cover_tilt now works. It is just controls that dont appear in discovered device.

@tsrubar
Copy link

tsrubar commented May 14, 2022

I just found out, that when I open entity, tilt controls are there. Maybe it would be more foolproof (I clearly am one) to have them exposed under normal shutter control.
image

@thecode
Copy link
Member

thecode commented May 14, 2022

Please do not comment over closed pull requests, if there is still an issue please create an issue at https://github.com/home-assistant/core/issues/new?assignees=&labels=&template=bug_report.yml

If you want to change the UI behaviour please create a feature request at https://community.home-assistant.io/c/feature-requests/13

Thanks 👍

@home-assistant home-assistant locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shutter tilt discovery for Tasmota native integration not working
4 participants