Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIN mode via acquisition function #340

Merged
merged 4 commits into from
Aug 30, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Import botorch.acquisition as bo_acqf
AdrianSosic committed Aug 30, 2024
commit c262ce8c48a4d84fd50fdf638a83a1edf098304e
8 changes: 4 additions & 4 deletions baybe/acquisition/base.py
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ def to_botorch(
The required structure of `measurements` is specified in
:meth:`baybe.recommenders.base.RecommenderProtocol.recommend`.
"""
import botorch.acquisition as bacqf
import botorch.acquisition as bo_acqf
import torch
from botorch.acquisition.objective import LinearMCObjective

@@ -66,7 +66,7 @@ def to_botorch(
train_y = objective.transform(measurements)

# Retrieve corresponding botorch class
acqf_cls = getattr(bacqf, self.__class__.__name__)
acqf_cls = getattr(bo_acqf, self.__class__.__name__)

# Match relevant attributes
params_dict = match_attributes(
@@ -91,9 +91,9 @@ def to_botorch(
if "best_f" in signature_params:
additional_params["best_f"] = train_y.min().item()

if issubclass(acqf_cls, bacqf.AnalyticAcquisitionFunction):
if issubclass(acqf_cls, bo_acqf.AnalyticAcquisitionFunction):
additional_params["maximize"] = False
elif issubclass(acqf_cls, bacqf.MCAcquisitionFunction):
elif issubclass(acqf_cls, bo_acqf.MCAcquisitionFunction):
additional_params["objective"] = LinearMCObjective(
torch.tensor([-1.0])
)