Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIN mode via acquisition function #340

Merged
merged 4 commits into from
Aug 30, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correctly determine best_f depending on mode
AdrianSosic committed Aug 30, 2024
commit 2bfe48c248075425b08c318da90960be62677170
10 changes: 6 additions & 4 deletions baybe/acquisition/base.py
Original file line number Diff line number Diff line change
@@ -78,18 +78,19 @@ def to_botorch(
additional_params = {}
if "model" in signature_params:
additional_params["model"] = surrogate.to_botorch()
if "best_f" in signature_params:
additional_params["best_f"] = train_y.max().item()
if "X_baseline" in signature_params:
additional_params["X_baseline"] = to_tensor(train_x)
if "mc_points" in signature_params:
additional_params["mc_points"] = to_tensor(
self.get_integration_points(searchspace) # type: ignore[attr-defined]
)

# Add acquisition objective
# Add acquisition objective / best observed value
match objective:
case SingleTargetObjective(NumericalTarget(mode=TargetMode.MIN)):
if "best_f" in signature_params:
additional_params["best_f"] = train_y.min().item()

if issubclass(acqf_cls, bacqf.AnalyticAcquisitionFunction):
additional_params["maximize"] = False
elif issubclass(acqf_cls, bacqf.MCAcquisitionFunction):
@@ -101,7 +102,8 @@ def to_botorch(
f"Unsupported acquisition function type: {acqf_cls}."
)
case SingleTargetObjective() | DesirabilityObjective():
pass
if "best_f" in signature_params:
additional_params["best_f"] = train_y.max().item()
case _:
raise ValueError(f"Unsupported objective type: {objective}")