Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Auto Location #711

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Deprecate Auto Location #711

merged 3 commits into from
Feb 26, 2021

Conversation

sandstrom
Copy link
Contributor

@sandstrom sandstrom commented Jan 23, 2021 •
edited
Loading

Rendered

Closes #693

@sandstrom sandstrom force-pushed the deprecate-auto-location branch from e96f112 to 20b20b2 Compare January 23, 2021 08:44
@sandstrom sandstrom mentioned this pull request Jan 23, 2021
Closed
@sandstrom sandstrom force-pushed the deprecate-auto-location branch from e36cc00 to 69aad84 Compare January 24, 2021 11:20
@rwjblue rwjblue self-assigned this Jan 25, 2021
rwjblue
rwjblue requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@sandstrom sandstrom requested a review from rwjblue January 29, 2021 14:17
@sandstrom
Copy link
Contributor Author

@rwjblue Thanks! I've updated the text with your suggestions

@rwjblue rwjblue added T-framework RFCs that impact the ember.js library T-routing Final Comment Period labels Feb 4, 2021
@rwjblue
Copy link
Member

rwjblue commented Feb 5, 2021

Discussed with the core team, and moving this into final comment period.

@rwjblue rwjblue merged commit 52ddbba into emberjs:master Feb 26, 2021
@sandstrom sandstrom deleted the deprecate-auto-location branch February 27, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees

@rwjblue rwjblue

Labels
Final Comment Period T-framework RFCs that impact the ember.js library T-routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Ember AutoLocation
2 participants
@sandstrom @rwjblue