-
-
Notifications
You must be signed in to change notification settings - Fork 408
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
139 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,139 @@ | ||
--- | ||
Stage: Accepted | ||
Start Date: 2021-01-23 | ||
Release Date: Unreleased | ||
Release Versions: | ||
ember-source: vX.Y.Z | ||
ember-data: vX.Y.Z | ||
Relevant Team(s): Ember.js | ||
RFC PR: https://github.com/emberjs/rfcs/pull/711 | ||
--- | ||
|
||
<!--- | ||
Directions for above: | ||
Stage: Leave as is | ||
Start Date: Fill in with today's date, YYYY-MM-DD | ||
Release Date: Leave as is | ||
Release Versions: Leave as is | ||
Relevant Team(s): Fill this in with the [team(s)](README.md#relevant-teams) to which this RFC applies | ||
RFC PR: Fill this in with the URL for the Proposal RFC PR | ||
--> | ||
|
||
# <RFC title> | ||
|
||
## Summary | ||
|
||
Deprecate Ember.AutoLocation and related APIs. In next major version, | ||
make history the default location (instead of auto). | ||
|
||
## Motivation | ||
|
||
In practice, 'auto' will almost always resolve to the 'history' location. | ||
|
||
By removing the 'auto' location and setting 'history' as the default we're removing | ||
some complexity around router location, with no downside for users, since they | ||
all get it resolved to history anyway. | ||
|
||
## Background | ||
|
||
The Ember Router can use different mechanisms to serialize its state. | ||
The two common ones are 'history' and 'hash'. There is also a special | ||
location called 'auto' which does feature detection, preferring 'history'. | ||
|
||
Basically all browsers will get 'history': | ||
https://caniuse.com/mdn-api_history_pushstate | ||
|
||
The check 'auto' is basically doing this: | ||
|
||
```js | ||
// Boosted from Modernizr: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/history.js | ||
// The stock browser on Android 2.2 & 2.3, and 4.0.x returns positive on history support | ||
// Unfortunately support is really buggy and there is no clean way to detect | ||
// these bugs, so we fall back to a user agent sniff :( | ||
|
||
// We only want Android 2 and 4.0, stock browser, and not Chrome which identifies | ||
// itself as 'Mobile Safari' as well, nor Windows Phone. | ||
|
||
if ( | ||
(userAgent.indexOf('Android 2.') !== -1 || userAgent.indexOf('Android 4.0') !== -1) && | ||
userAgent.indexOf('Mobile Safari') !== -1 && | ||
userAgent.indexOf('Chrome') === -1 && | ||
userAgent.indexOf('Windows Phone') === -1 | ||
) { | ||
return false; | ||
} | ||
|
||
return Boolean(window.history && 'pushState' in window.history); | ||
``` | ||
|
||
## Transition Path | ||
|
||
We'll begin with deprecating history, in next major release we | ||
set history as the default. Since auto is default today, | ||
and almost always resolve to history, most users won't need | ||
to do a thing and they'll still get history behavior in the | ||
next major release. | ||
|
||
There are two groups to consider: | ||
|
||
1. People who need auto-detection (hash/history switching) and | ||
2. Those that have explicitly set location to 'auto'. | ||
|
||
For the first group the solution is fairly trivial. Simply | ||
implement feature detection, via e.g. Modernizr[1], like this: | ||
|
||
```js | ||
// app/router.js | ||
export default class Router extends EmberRouter { | ||
location = (historyFeatureDetection() ? 'history' : 'hash'); | ||
// … | ||
} | ||
``` | ||
|
||
For the second group, they simply need to replace their explicit choice | ||
of 'auto' for 'history' in `locationType` in environment.js (or | ||
`location` in router.js), since history is what their 'auto' resolves | ||
to anyway. | ||
|
||
### What To Deprecate (and later remove) | ||
|
||
- The HistoryLocation class | ||
- The method `detect` from the `Location` interface | ||
- Explicitly setting 'auto' as the preferred location. | ||
|
||
### Deprecated or already private (should also be removed) | ||
- Remove the `create` method on Location (replaced by registry) | ||
- `registerImplementation` method on `Location` | ||
- `supportsHistory` exported in location/utils.ts | ||
|
||
## How We Teach This | ||
|
||
- Remove the text about auto location from guides. | ||
- There is already good documentation about the different | ||
location types (history, hash, none) and how to write your own. | ||
- Slight adjustments needed for the guides, removing mentions of auto[2]. | ||
|
||
Overall there should be fairly little changes to how Ember is taught. Since | ||
the vast majority of users will need to make zero code changes and will have | ||
zero change in actual behaviour. | ||
|
||
## Drawbacks | ||
|
||
Anyone using an unsupported browser will need to do feature detection | ||
in their own code base or opt everyone into using the hash location. | ||
|
||
https://caniuse.com/mdn-api_history_pushstate | ||
|
||
## Alternatives | ||
|
||
Do nothing. | ||
|
||
## Unresolved questions | ||
|
||
There are currently no unresolved questions. | ||
|
||
## References | ||
|
||
[1] https://github.com/Modernizr/Modernizr/blob/master/feature-detects/history.js | ||
[2] https://guides.emberjs.com/release/configuring-ember/specifying-url-type/ |