Unexpected reserved word in strict mode error (for yield) on Android 4.0

[fivetanley]

The line on HTMLBars here: https://github.com/tildeio/htmlbars/blob/72c7350805e4d7d44e2e88f2377915960cd3513a/packages/htmlbars-runtime/lib/hooks.js#L107

causes an error of Unexpected reserved word in strict mode error on Android 4.0. The solution is probably to add 'yield' to https://github.com/stefanpenner/es3-safe-recast.

[fivetanley]

Another example on another project: angular/angular.js#7969

[rwjblue]

Dupe of tildeio/htmlbars#420, which would be fixed by tildeio/htmlbars#421.

[fivetanley]

I was getting Saucelabs set up for Ember Data which made me notice this. Glad it's been fixed! I think we'll need a point release for the changes to apply? I'm also concerned about previous versions of ember.

[rwjblue]

Ya, we will need to release updated version of HTMLBars for Ember versions 1.13 (kinda like an LTS), 2.2 (release), and 2.3 (beta).

[mmun]

I am confused. Babel should be handling this?

https://babeljs.io/repl/#?experimental=false&evaluate=true&loose=false&spec=false&code=var%20x%20%3D%20%7B%20'yield'%3A%20true%2C%20yield%3A%20false%20%7D%3B

[stefanpenner]

@mmun I don't believe old builds always used babel.

[fivetanley]

FWIW this is now in es3-safe-recast thanks to @stefanpenner, so it may be as simple as bumping the version + doing rebuild.

[rwjblue]

Nothing is simple with older deps and npm. ;P

[Serabe]

Closing this since 1.13 is no longer LTSish and the fix was in htmlbars 0.14.11 (the version in Ember 2.3).

Please, reopen it if something is still missing.