Skip to content
This repository was archived by the owner on Apr 4, 2019. It is now read-only.

Syntax Error in Android Browser API Level <= 15 #420

Open
davidgoli opened this issue Sep 30, 2015 · 5 comments
Open

Syntax Error in Android Browser API Level <= 15 #420

davidgoli opened this issue Sep 30, 2015 · 5 comments

Comments

@davidgoli
Copy link
Contributor

Admittedly this is an older browser, affecting as of this writing 8% of the Android market, but I thought I'd submit this for the record:

  • open an HTMLBars-dependent client app (eg. an Ember CLI >= 1.13 app) in an Android browser running API level 15 or below (aka Ice Cream Sandwich, v4.0.4) - including an emulator

result: JavaScript syntax error: "Unexpected strict mode reserved word"

The web app fails to continue to load and will not run, thus making it unusable for users of devices at this API level.

Tracked the offending line down to:

Related issue: cujojs/when#89

Does not repro on Android browsers >= API level 16.

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 30, 2015

Would you mind sending in a PR quoting 'yield'?

@davidgoli
Copy link
Contributor Author

Done. Hopefully uglifiers won't strip the quotes...

@mmun
Copy link
Collaborator

mmun commented Sep 30, 2015

Shouldn't babel be handling this?

@davidgoli
Copy link
Contributor Author

I can confirm that this change does indeed fix this issue.

@davidgoli
Copy link
Contributor Author

But it does seem like a nice-to-have for the Babel processor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants