-
Notifications
You must be signed in to change notification settings - Fork 5k
Disable Filebeat's azure-eventhub
input and azure
module in FIPS builds
#44902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
1517530
to
2bd14ee
Compare
2bd14ee
to
b176324
Compare
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Proposed commit message
This PR ensures that the Filebeat
azure
module is only included in non-FIPS builds of Filebeat. It also ensures that the Filebeatazure-eventhub
input, which is used by the theazure
module, is only included in non-FIPS builds of Filebeat. In other words, neither theazure
module nor theazure-eventhub
input will be available in FIPS-capable Filebeat artifacts.The
azure-eventhub
input depends on the Azure Go SDK. The SDK's code uses thegolang.org/x/crypto/pkcs12
package, which is not FIPS-compliant, and the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).As such, we have little choice but to exclude the
azure-eventhub
input and the only module that uses it,azure
, from FIPS-capable Filebeat builds.Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
FIPS-capable artifacts of Filebeat will not contain the
azure
module or theazure-eventhub
input.