-
Notifications
You must be signed in to change notification settings - Fork 5k
Disable Filebeat's o365audit
input and o365
module in FIPS builds
#44909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
1d00ef8
to
3815c3a
Compare
3815c3a
to
f592d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like two PRs, one enabling and one that is what's described on the tin. Could we separate them? Also, please include the import path that leads to the concerning import.
Created #44920 to enable the module exclusion. Will rework this PR here to only be about what's on the tin once the enabling PR is merged. |
Update the PR description. Let me know if that looks good to you. |
Thanks. Crystal clear now. |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Proposed commit message
This PR ensures that the Filebeat
o365
module is only included in non-FIPS builds of Filebeat. It also ensures that the Filebeato365audit
input, which is used by the theo365
module, is only included in non-FIPS builds of Filebeat. In other words, neither theo365
module nor theo365audit
input will be available in FIPS-capable Filebeat artifacts.The
o365audit
input depends on the Azure Go SDK, specifically the6github.com/Azure/azure-sdk-for-go/sdk/azidentity
package. This package uses thegolang.org/x/crypto/pkcs12
package, which is not FIPS-compliant, and the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).As such, we have little choice but to exclude the
o365audit
input and the only module that uses it,o365
, from FIPS-capable Filebeat builds.Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
FIPS-capable artifacts of Filebeat will not contain the
o365
module or theo365audit
input.