iox-#831 Replace MethodCallback with cxx::function

[mossmaurice]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

• Replaces MethodCallback with cxx::function
• Removes unused Trigger::updateOrigin method

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Use cxx::function were it is appropriate #831

[codecov]

Codecov Report

Merging #1423 (f2586e0) into master (4763bd9) will decrease coverage by 0.08%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   78.83%   78.75%   -0.09%     
==========================================
  Files         378      376       -2     
  Lines       14579    14486      -93     
  Branches     2027     2013      -14     
==========================================
- Hits        11493    11408      -85     
- Misses       2432     2433       +1     
+ Partials      654      645       -9     

Flag	Coverage Δ
unittests	78.41% <77.77%> (-0.09%)	⬇️
unittests_timing	14.80% <77.77%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sh/include/iceoryx_posh/internal/popo/listener.inl	91.89% <ø> (ø)
...osh/include/iceoryx_posh/internal/popo/trigger.inl	100.00% <ø> (+4.16%)	⬆️
...nternal/roudi/introspection/port_introspection.hpp	100.00% <ø> (ø)
iceoryx_posh/source/popo/listener.cpp	87.80% <50.00%> (+2.09%)	⬆️
iceoryx_posh/source/popo/trigger.cpp	92.45% <66.66%> (ø)
...eoryx_posh/internal/popo/notification_attorney.inl	100.00% <100.00%> (ø)
...sh/include/iceoryx_posh/internal/popo/wait_set.inl	91.17% <100.00%> (ø)
iceoryx_posh/source/popo/trigger_handle.cpp	89.65% <100.00%> (ø)
...nternal/roudi/introspection/port_introspection.inl	82.11% <0.00%> (-0.73%)	⬇️

[elfenpiff]

Looks good, as soon as the CI is green I would approve it

[mossmaurice]

@elBoberido LSAN issue was fixed by adding the flag intercept_tls_get_addr=0. AFAIU a new dynamic thread local storage test was added to LeakSan, which causes the error with certain glibc versions under certain conditions. The fix was adopted by many projects e.g. Chromium, neovim and others (see google/sanitizers#1322).