split get address test into success and failure cases #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving a domain may result in either an ipv4 or ipv6 address in the current implementation. Therefore, split the localhost (success) and others (failure). Signed-off-by: Michael Engel <[email protected]>
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving a domain may result in either an ipv4 or ipv6 address in the current implementation. Therefore, split the localhost (success) and others (failure) test cases and check for the localhost test to resolve either to
127.0.0.1or::1. This will fix the current failure when building on COPR: https://copr.fedorainfracloud.org/coprs/mperina/hirte-snapshot/build/6105555/