-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ipv4 ipv6 handling #363
Conversation
b2bd5bf
to
f41cfc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general LGTM just small comments. Please let me know when is ready for Tests.
5c6fa90
to
12478d4
Compare
Also, if possible, could you please squash the commits? Would be easier to review :) |
- enabled setting of ipv6 orch address - renamed isIPv4Addr and isIPv6Addr to be snake case - introduced agent_reconnect - added integration test for fqdn to ip resolving Signed-off-by: Michael Engel <[email protected]>
12478d4
to
37d5c43
Compare
make test is failing on my env but looks like it's something local, CI on github just worked:
For the record: I am using a dualstack env. |
We can handle these minor changes in a different patch, it's getting big here. |
This actually broke the COPR build: https://copr.fedorainfracloud.org/coprs/mperina/hirte-snapshot/build/6105555/ |
This PR is a follow-up of #353 and refactors the IPv4/IPv6 handling as well as adds setting the assembled IPv6 orchestrator address.
Still missing (and will be added in this PR):