Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tableString for search fix #582 #824

Closed
wants to merge 2 commits into from

Conversation

wjhrdy
Copy link

@wjhrdy wjhrdy commented Apr 18, 2019

Create Table String for Search

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

Copy link
Member

@timaschew timaschew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I would prefer a more functional approach for the logic using .map instead of .forEach.

@wjhrdy
Copy link
Author

wjhrdy commented Apr 24, 2019

I think this is what you were looking for 1b9710a

@wjhrdy
Copy link
Author

wjhrdy commented Apr 24, 2019

It doesn't create the exact same string but I think its just fine for searching to create
cell | cell | cell |\n cell | cell | cell

rather than

| cell | cell | cell | cell | cell | cell |

@wjhrdy
Copy link
Author

wjhrdy commented May 3, 2019

Anything else you need me to do?

@timaschew
Copy link
Member

Can you please add a test case. I've tried your changes locally but it doesn't work.
It doesn't enter this case} else if (token.type === 'table'){

@wjhrdy
Copy link
Author

wjhrdy commented May 6, 2019

Where do I add a test case? sorry for my ignorance.

@melloware
Copy link

Any update on this? This feature is a huge improvement for usability.

@wjhrdy
Copy link
Author

wjhrdy commented Aug 23, 2019

im using it already. i just dont know where to write tests

@tandraschko
Copy link

Any update on this?

@wjhrdy
Copy link
Author

wjhrdy commented Oct 16, 2019

I think it can be merged. I'm not sure what else has to be done.

@felangel
Copy link
Contributor

felangel commented Oct 16, 2019

As @timaschew mentioned you should add unit tests to validate your changes and to ensure they remain intact over time. I can try to help later today if you’re having trouble writing tests for the added functionality.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@anikethsaha
Copy link
Member

Can you please provide some snapshots for these changes. I cant review this as we don't have tests to validate this.

@sy-records
Copy link
Member

@anikethsaha Hello, can this pr fix #582 ? I also encountered this problem, or does the official have time to fix it?

@sy-records sy-records mentioned this pull request Feb 5, 2020
19 tasks
@difosfor
Copy link

difosfor commented Feb 7, 2020

I'd also like to see support for searching table contents. If you need some test content, perhaps you can look at our documentation? https://docs.liveryvideo.com/web-sdk

Let me know if/how I can help.

@anikethsaha
Copy link
Member

closed by #1015

@anikethsaha anikethsaha closed this Feb 7, 2020
@anikethsaha
Copy link
Member

I'd also like to see support for searching table contents. If you need some test content, perhaps you can look at our documentation? https://docs.liveryvideo.com/web-sdk

Let me know if/how I can help.

the PR is merged with this fix,
You can test the new build from github to see if anything is breaking in searching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants