fix #582 and #824 #1015
fix #582 and #824 #1015
Conversation
There was a problem hiding this comment.
Also, if we consider fuzzy for searching #841 , then I guess this changes will break
| if (!token.text) { | ||
| if (token.type === 'table') { | ||
| token.text = token.cells.map(function (rows) { | ||
| return rows.join(' | ') | ||
| }).join(' |\n ') | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is from #582 right ?
I guess we should wait for his response for a while if its inactive then we can work here
There was a problem hiding this comment.
Yes, but I need to use it. I'm not sure what problems will be caused by this modification, and I can't find it after adding some descriptions mentioned in the test case. How should I solve this?
There was a problem hiding this comment.
These changes look fine to me, and I think it won't break anything else.
cc @docsifyjs/core , can you guys review this
There was a problem hiding this comment.
Nice, lets wait for #582 for a while and review from other members 👍
|
Sorry, I am not a front-end developer and I am not very familiar with front-end.😅 |
|
token-based searching is one of the ways and the changes you did seems like that. |
|
OK, thanks. |
Summary
fix #582 and #824, I also encountered this problem, tried to fix and update a bit.
Fix the problem that the content of the table cannot be searched, But there are still some problems here, adding some descriptions will not search.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
In #824 , he did not provide test cases, I provide here.
libdirectory.