Skip to content

Call getProperty can be simplified for line.separator #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Pankraz76
Copy link
Contributor

Call getProperty can be simplified for line.separator.

discovering by:

@Pankraz76 Pankraz76 marked this pull request as ready for review June 24, 2025 10:49
@nedtwigg
Copy link
Member

We don't have a style guide against static imports, but every file which this PR touches adds the first such static import to that file. The points of Spotless is to spend less time on style. If this was a simplification I would merge it anyway because again I don't want to spend time on style, but it actually adds lines

image

Thank you for this batch of PRs, but I'm going to close this unmerged. Stylistic changes that we can't keep enforced are imo noise, but it's not a big deal :)

@nedtwigg nedtwigg closed this Jun 24, 2025
@Pankraz76
Copy link
Contributor Author

not a big deal

to create a recipe hopefully, as its noise due to IDE warnings imposed.

don't want to spend time on style

agree.

but it actually adds lines

yes, imports are blind to dev, as in contrast the context class System is not. Consider this boilerplate as lineseparator only known to be originating from the System class.

So this would actually move the overhead from statement to import area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants