-
Notifications
You must be signed in to change notification settings - Fork 481
Avoid empty body warnings imposed by default activation of expandEmptyElements #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
48ccc6b
to
300e68b
Compare
Would you mind adding tests for this? |
no of course not, will impose QA. |
missing format. Im used to maven and quarkus fixing itself, not having to run the goal manually. Can we impose this here as well plz? Run |
is it a feature then, or dont we need convention commits on this? |
Nah, we don't use conventional commits in this project. :) |
Oh, how so? How do Maven and Quarkus do this? |
thanks for interest. please see here: |
This comment was marked as off-topic.
This comment was marked as off-topic.
@@ -27,7 +27,7 @@ public class SortPomCfg implements Serializable { | |||
|
|||
public String lineSeparator = System.getProperty("line.separator"); | |||
|
|||
public boolean expandEmptyElements = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maven user - does this affect end-user behavior enough that we should note it in the CHANGELOG.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not be important enough to warrant urgent attention.
On the other hand, many of these cases may now be obsolete, since the Convention over Configuration principle is now fixed and no longer needs to be overridden, from outside.
Ideally, a new build should even fail, given attention that the config has now changed, as the relevant client code is now redundant/wrong:
<expandEmptyElements>false</expandEmptyElements>
https://github.com/apache/maven-parent/blob/f4ab7c2eb04865071186c57a263243c72b6e8d52/pom.xml#L1236
If you want me to add some notes, let me know.
Closes #2519.