This repository was archived by the owner on Sep 7, 2022. It is now read-only.
Bump to go 1.17.0
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps to `go` `1.16.7` generated via: ``` $ docker run -v ~/Code/open-source/dependabot/gomodules-extracted:/gomodules -it --rm golang:1.16.7 root@f5a9ea6a8efe:/go# cd /gomodules/ root@f5a9ea6a8efe:/gomodules# ./script/extract ```
This bumps to `go` `1.17.0` generated via: ``` $ docker run -v ~/Code/open-source/dependabot/gomodules-extracted:/gomodules -it --rm golang:1.17.0 root@f5a9ea6a8efe:/go# cd /gomodules/ root@f5a9ea6a8efe:/gomodules# ./script/extract ```
jeffwidman
commented
Aug 19, 2021
| // LoadModFile checks the roots of the module graph for consistency with each | ||
| // other, but unlike LoadModGraph does not load the full module graph or check | ||
| // it for global consistency. Most callers outside of the modload package should | ||
| // use LoadModGraph instead. |
There was a problem hiding this comment.
Perhaps dependabot should be updated to use LoadModGraph instead? A question to be solved over in dependabot/dependabot-core#4153.
jeffwidman
commented
Aug 19, 2021
| // other, but unlike LoadModGraph does not load the full module graph or check | ||
| // it for global consistency. Most callers outside of the modload package should | ||
| // use LoadModGraph instead. | ||
| func LoadModFile(ctx context.Context) *Requirements { |
There was a problem hiding this comment.
The LoadModFile signature changed, so this will be a breaking change for dependabot-core.
Regardless, the fix will have to be made in dependabot-core, not here, as this is effectively a mirror of upstream go code, so we get whatever they give us.
mctofu
approved these changes
Aug 19, 2021
mctofu
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 19, 2021
- Acknowledge we aren't using the return value - Disable writes to go.mod which is a new go 1.17 behavior dependabot/gomodules-extracted#12 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11, that should probably be merged first.
This bumps to
go1.17.0generated via: