Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to bump to a version of https://github.com/dependabot/gomodules-extracted/ that uses go 1.17 code #4153

Closed
jeffwidman opened this issue Aug 19, 2021 · 2 comments
Labels
T: bug 🐞 Something isn't working

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Aug 19, 2021

It's awesome that go 1.17 landed in https://github.com/dependabot/dependabot-core/pull/4149/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R170-R171.

However, the underlying gomodules-extracted code also changed significantly during the upstream 1.17 release.
So need to bump that to keep things in-sync... otherwise we may inadvertently get 1.16 behavior while thinking we are getting 1.17 behavior.

I opened a PR dependabot/gomodules-extracted#12 to update that repo. Once that's merged and a new release cut, will need to update here.

This code only uses two functions from gomodules-extracted:

  • github.com/dependabot/gomodules-extracted/cmd/go/_internal_/modfetch.Lookup ➡️ signature and behavior unchanged.
  • github.com/dependabot/gomodules-extracted/cmd/go/_internal_/modload.LoadModFile(context.Background()) ➡️ signature and behavior did change, so will need some tweaking here as part of pulling it in. Also, should check if LoadModGraph is a better fit.
@mctofu
Copy link
Contributor

mctofu commented Aug 19, 2021

Thanks for the analysis! A PR to update gomodules-extracted and adapt to the changes is here: #4157.

@jeffwidman
Copy link
Member Author

Closed by #4157

See also #4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants