Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add compatibility for go1.17 and older #4149

Merged
merged 5 commits into from
Aug 18, 2021
Merged

chore: Add compatibility for go1.17 and older #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29c065b
chore: Add compatibility for go11.17 and older
obalunenko Aug 18, 2021
2e320f9
Fix go version
obalunenko Aug 18, 2021
8636d82
Fix rubocop new line lint warning
obalunenko Aug 18, 2021
774e120
Remove -compat flag from go mod tidy
obalunenko Aug 18, 2021
b5833e4
Handle different unreachable module message from go 1.17
mctofu Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ USER root
### GO

# Install Go
ARG GOLANG_VERSION=1.16.7
ARG GOLANG_CHECKSUM=7fe7a73f55ba3e2285da36f8b085e5c0159e9564ef5f63ee0ed6b818ade8ef04
ARG GOLANG_VERSION=1.17
ARG GOLANG_CHECKSUM=6bf89fc4f5ad763871cf7eac80a2d594492de7a818303283f1366a7f6a30372d
ENV PATH=/opt/go/bin:$PATH
RUN cd /tmp \
&& curl --http1.1 -o go.tar.gz https://dl.google.com/go/go${GOLANG_VERSION}.linux-amd64.tar.gz \
Expand Down
2 changes: 1 addition & 1 deletion go_modules/lib/dependabot/go_modules/file_updater/go_mod_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class GoModUpdater
/fatal: The remote end hung up unexpectedly/,
/repository '.+' not found/,
# (Private) module could not be fetched
/go: .*: git fetch .*: exit status 128/m.freeze,
/go: .*: git (fetch|ls-remote) .*: exit status 128/m.freeze,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In go 1.17 two of the test cases from #4130 changed:

error go 1.16 go 1.17
direct dependency unreachable go: github.com/dependabot-fixtures/[email protected]: reading github.com/dependabot-fixtures/go-modules-private/go.mod at revision v0.0.1: unknown revision v0.0.1 go: github.com/dependabot-fixtures/[email protected]: reading github.com/dependabot-fixtures/go-modules-private/go.mod at revision v0.0.1: git ls-remote -q origin in /home/dependabot/go/pkg/mod/cache/vcs/51c9292b9f45a35312c3863da5428630dd2a800586fd865c7065132199b41694: exit status 128: fatal: could not read Username for 'https://github.com': terminal prompts disabled Confirm the import path was entered correctly. If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.
sub dependency unreachable go: github.com/dependabot-fixtures/[email protected] requires github.com/dependabot-fixtures/[email protected]: reading github.com/dependabot-fixtures/go-modules-private/go.mod at revision v0.0.1: unknown revision v0.0.1 go: github.com/dependabot-fixtures/[email protected] requires github.com/dependabot-fixtures/[email protected]: reading github.com/dependabot-fixtures/go-modules-private/go.mod at revision v0.0.1: git ls-remote -q origin in /home/dependabot/go/pkg/mod/cache/vcs/51c9292b9f45a35312c3863da5428630dd2a800586fd865c7065132199b41694: exit status 128: fatal: could not read Username for 'https://github.com': terminal prompts disabled Confirm the import path was entered correctly. If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.

# (Private) module could not be found
/cannot find module providing package/.freeze,
# Package in module was likely renamed or removed
Expand Down