#3088. Remove weak mode from LanguageFeatures/nnbd. Part 2.

[sgrekhov]

Again small formatting added. Removed or added empty lines

[eernstg]

It's a 46707 line diff, and it seems to include (1) a rather large number of completely new libraries, (2) a somewhat similar number of deleted libraries, as well as (3) removal of // Requirements=nnbd-strong, (4) some bug fixes (changing libFunc to libFunc() and such, in Parts-with-imports), (5) renaming enum-shorthands to dot-shorthands, and (6) moving @issue around in a few cases. I'm not sure, but it seems likely that some of those new/deleted cases would actually be renamings.

It would be great if the diff could be made less massive and more homogeneous (hence: easier to read) by separating those elements into a handful of simpler PRs.

[sgrekhov]

@eernstg, how can you see that diff? It's a rather big diff, but it contains: (1) the removal of // Requirements=nnbd-strong, (2) the removal of excessive empty lines, (3) the addition of empty lines where needed, and (4) the removal of files containing // Requirements=nnbd-weak. There are no changes involving the addition of new libraries or the renaming of enum-shorthands to dot-shorthands. Are you looking at the diff shown when you click the 'Files changed' tab on this GitHub page?

[eernstg]

With a PR that changes many files, I'm usually fetching it (here: gh pr checkout 3094) and using various command line tools to understand what's going on. This yields the 46707 line diff.

Ah! Now I can see what happened:

We just had a lot of hardware network changes during the weekend so I had to start using a cloudtop because there was no access to my usual desktop. So I was working from a backup on the cloudtop, and the co19 repo wasn't up to date (even though I had just fetched all updates when I had access to the desktop for a short period of time). So I compared this branch with a not-quite new master, which introduced a bunch of spurious changes.

With the fetch, the diff is 3803 lines. ;-)

[eernstg]

LGTM, when looking carefully! ;-)

[sgrekhov]

Thanx!

[eernstg]

Thanks!