Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3057. Add tests for method invocation #3083

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

sgrekhov
Copy link
Contributor

Please review. In the spec we also have:

Binary operator: All binary operators other than ==, &&, ||, and ?? are handled as calls to the appropriate operator method.

So, if these tests are Ok, then I'm going to add the similar tests for E1 + E2 and all other operators with two operands.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments!

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Mar 3, 2025

Updated. Added cases for getter returning callable object and type Never. PTAL.

@sgrekhov sgrekhov requested a review from eernstg March 3, 2025 10:15
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think a couple of descriptions got slightly garbled at some point.

@sgrekhov sgrekhov requested a review from eernstg March 4, 2025 09:36
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 432cf3f into dart-lang:master Mar 4, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 7, 2025
2025-03-06 [email protected] dart-lang/co19#3057. Add reachability tests for operators. Part 3. (dart-lang/co19#3100)
2025-03-06 [email protected] dart-lang/co19#3057. Add reachability tests for operators. Part 2. (dart-lang/co19#3099)
2025-03-06 [email protected] dart-lang/co19#3057. Add reachability tests for operators. Part 1. (dart-lang/co19#3098)
2025-03-05 [email protected] dart-lang/co19#3057. Add reachability tests for operator + (dart-lang/co19#3097)
2025-03-05 [email protected] dart-lang/co19#3057. Add tests for cascade method invocation (dart-lang/co19#3095)
2025-03-05 [email protected] Closes dart-lang/co19#3088. Remove weak mode from LanguageFeatures/Patterns. (dart-lang/co19#3096)
2025-03-05 [email protected] dart-lang/co19#3088. Remove weak mode from LanguageFeatures/nnbd. Part 2. (dart-lang/co19#3094)
2025-03-04 [email protected] dart-lang/co19#3057. Add tests for method invocation (dart-lang/co19#3083)
2025-03-04 [email protected] dart-lang/co19#3088. Remove weak mode from LanguageFeatures/nnbd. Part 1. (dart-lang/co19#3092)
2025-03-04 [email protected] dart-lang/co19#3088. Remove weak mode from Language and LibTest (dart-lang/co19#3093)
2025-03-03 [email protected] dart-lang/co19#3088. Remove weak mode from TypeSystem/subtyping (dart-lang/co19#3091)
2025-03-03 [email protected] dart-lang/co19#3088. Remove weak mode from TypeSystem/type-normalization (dart-lang/co19#3089)
2025-03-03 [email protected] dart-lang/co19#3088. Remove weak mode from TypeSystem/flow-analysis (dart-lang/co19#3090)
2025-03-03 [email protected] Fixes dart-lang/co19#3086. Update context type for expected value (dart-lang/co19#3087)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ib3b8714c4d6ae5d73089b41374ed3ce16b6ddab0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414220
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants