-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2485. Add constant evaluation tests for Set
#2509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of typos.
Thank you! Typos are fixed. Please take another look |
eernstg
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 26, 2024
2024-01-26 [email protected] dart-lang/co19#2485. Add constant evaluation tests for `Set` (dart-lang/co19#2509) 2024-01-26 [email protected] Fixes dart-lang/co19#2507. Fix roll failures (dart-lang/co19#2508) 2024-01-26 [email protected] dart-lang/co19#2485. Add is T constant evaluation tests (dart-lang/co19#2501) 2024-01-26 [email protected] dart-lang/co19#2485. Add `is! T` constant evaluation tests (dart-lang/co19#2504) 2024-01-25 [email protected] Fixes dart-lang/co19#2503. Update exhaustiveness_map_A02_t02.dart according to the flow analysis change (dart-lang/co19#2503) 2024-01-25 [email protected] dart-lang/co19#2420. Exhaustiveness variable tests. Add switch statement check (dart-lang/co19#2453) 2024-01-22 [email protected] dart-lang/co19#2485. Add more constant evaluation tests for record types (dart-lang/co19#2499) 2024-01-22 [email protected] dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2498) Change-Id: If4af6cc1df4d44ad01e3578b8524748f67e7bac4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348660 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
Add constant evaluation tests for `Set`
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
Add constant evaluation tests for `Set`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.