Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2485. Add constant evaluation tests for Set #2509

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

@sgrekhov sgrekhov requested review from eernstg and athomas January 26, 2024 11:07
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of typos.

@sgrekhov
Copy link
Contributor Author

Thank you! Typos are fixed. Please take another look

@sgrekhov sgrekhov requested a review from eernstg January 26, 2024 13:25
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit af2ac96 into dart-lang:master Jan 26, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 26, 2024
2024-01-26 [email protected] dart-lang/co19#2485. Add constant evaluation tests for `Set` (dart-lang/co19#2509)
2024-01-26 [email protected] Fixes dart-lang/co19#2507. Fix roll failures (dart-lang/co19#2508)
2024-01-26 [email protected] dart-lang/co19#2485. Add is T constant evaluation tests (dart-lang/co19#2501)
2024-01-26 [email protected] dart-lang/co19#2485. Add `is! T` constant evaluation tests (dart-lang/co19#2504)
2024-01-25 [email protected] Fixes dart-lang/co19#2503. Update exhaustiveness_map_A02_t02.dart according to the flow analysis change (dart-lang/co19#2503)
2024-01-25 [email protected] dart-lang/co19#2420. Exhaustiveness variable tests. Add switch statement check (dart-lang/co19#2453)
2024-01-22 [email protected] dart-lang/co19#2485. Add more constant evaluation tests for record types (dart-lang/co19#2499)
2024-01-22 [email protected] dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2498)

Change-Id: If4af6cc1df4d44ad01e3578b8524748f67e7bac4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348660
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this pull request Feb 15, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants