-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2485. Add is T constant evaluation tests #2501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of glitches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Updated. Please take another look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2024-01-26 [email protected] dart-lang/co19#2485. Add constant evaluation tests for `Set` (dart-lang/co19#2509) 2024-01-26 [email protected] Fixes dart-lang/co19#2507. Fix roll failures (dart-lang/co19#2508) 2024-01-26 [email protected] dart-lang/co19#2485. Add is T constant evaluation tests (dart-lang/co19#2501) 2024-01-26 [email protected] dart-lang/co19#2485. Add `is! T` constant evaluation tests (dart-lang/co19#2504) 2024-01-25 [email protected] Fixes dart-lang/co19#2503. Update exhaustiveness_map_A02_t02.dart according to the flow analysis change (dart-lang/co19#2503) 2024-01-25 [email protected] dart-lang/co19#2420. Exhaustiveness variable tests. Add switch statement check (dart-lang/co19#2453) 2024-01-22 [email protected] dart-lang/co19#2485. Add more constant evaluation tests for record types (dart-lang/co19#2499) 2024-01-22 [email protected] dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2498) Change-Id: If4af6cc1df4d44ad01e3578b8524748f67e7bac4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348660 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
Add `is T` constant evaluation tests
Add `is T` constant evaluation tests
No description provided.