Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grays out site packages in tracebacks #33

Merged
merged 13 commits into from
Nov 1, 2017
Merged

grays out site packages in tracebacks #33

merged 13 commits into from
Nov 1, 2017

Conversation

dmalan
Copy link
Member

@dmalan dmalan commented Oct 29, 2017

If user does import cs50 or from cs50 import..., tracebacks are darkened per below.

CLI

before

cli2-before

cli-before

after

cli2-after

cli-after

Flask

before

flask-before

after

flask-after

@dmalan
Copy link
Member Author

dmalan commented Oct 29, 2017

@glennholloway @kzidane @crossroads1112 @brianyu28 @curiouskiwi what do you think? Much like the library transparently disables stdout/stderr buffering, so is this feature meant to facilitate development and debugging for students. Rather than hide system files altogether, it simply grays them out to highlight students' own code.

@dmalan
Copy link
Member Author

dmalan commented Oct 30, 2017

@glennholloway @kzidane @crossroads1112 @brianyu28, updated screenshots and code itself. Adds Flask support now.

@dmalan
Copy link
Member Author

dmalan commented Nov 1, 2017

@brianyu28 mind testing this out before I merge?

@brianyu28
Copy link
Member

Tested, seems to work on the errors I tried!

@dmalan dmalan merged commit 41b0c47 into develop Nov 1, 2017
@dmalan dmalan deleted the excepthook branch November 1, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants