Skip to content
This repository was archived by the owner on Nov 14, 2020. It is now read-only.

removes FLASK_DEBUG, adds --reload #184

Merged
merged 7 commits into from
Nov 8, 2017
Merged

removes FLASK_DEBUG, adds --reload #184

merged 7 commits into from
Nov 8, 2017

Conversation

dmalan
Copy link
Member

@dmalan dmalan commented Oct 30, 2017

Should only be merged after cs50/python-cs50#33 is.

@dmalan dmalan requested a review from kzidane October 30, 2017 02:47
@dmalan
Copy link
Member Author

dmalan commented Oct 30, 2017

@kzidane where is python-cs50 installed?

@kzidane
Copy link
Member

kzidane commented Oct 30, 2017

@dmalan
Copy link
Member Author

dmalan commented Oct 30, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dmalan
Copy link
Member Author

dmalan commented Nov 8, 2017

Ready to merge, @kzidane !

@kzidane
Copy link
Member

kzidane commented Nov 8, 2017

Don't think the parentheses are needed here. Maybe there were before and we left after simplification. Just rebased on develop. Will merge shortly after testing.

This was referenced Nov 8, 2017
@kzidane kzidane merged commit 3d05de3 into develop Nov 8, 2017
@kzidane kzidane deleted the flask branch November 8, 2017 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants