Redo DateTimeInput with downshift #282
Conversation
dferber90
force-pushed
the
df-redo-date-input-using-downshift
branch
from
df503d4 to
5d790e5
Compare
dferber90
force-pushed
the
df-redo-date-time-input-using-downshift
branch
from
8f9f94d to
6e5e083
Compare
| @@ -0,0 +1,135 @@ | |||
| // Difference of this file to utils.js is that this file | |||
There was a problem hiding this comment.
why the name calendar-time?
There was a problem hiding this comment.
Those are utilities for a calendar which respects time. It was really hard to find good names here. We need the utils to:
- share logic between the calendars (
DateInput&DateRangInput).DateTimeInputuses its own utils (this file). - keep the date library (
moment) out of our components which makes them more readable and makes it easier to replace the date-library if we ever want to
| return addFlatpickrOffset(value, timeZone); | ||
| const preventDownshiftDefault = event => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| event.nativeEvent.preventDownshiftDefault = true; |
There was a problem hiding this comment.
That's a really nice way to give a lot of opt-in control to consumers.
| getDaysInMonth(today, this.props.timeZone) - | ||
| 1, | ||
| }), | ||
| () => this.inputRef.current.focus() |
|
Nitpick: can the default day be highlighted a bit more? It's a bit "hard" to see the blue color. Also the months/years do not seem to be aligned correctly.
|
The blue color represents "today". It is not the default highlighted date.A highlight looks like this. The 14th is highlighted here.
Thanks for the hint. This was a problem in Firefox only. I fixed it there now (in #281). |
dferber90
force-pushed
the
df-redo-date-input-using-downshift
branch
from
3ac9eb3 to
2932680
Compare
dferber90
changed the base branch from
df-redo-date-input-using-downshift
to
master
dferber90
force-pushed
the
df-redo-date-time-input-using-downshift
branch
from
6e5e083 to
0da4c39
Compare
dferber90
force-pushed
the
df-redo-date-time-input-using-downshift
branch
from
0da4c39 to
89d0e0b
Compare
This is the new
DateTimeInputbased ondownshift.See also #281 which replaces
DateInput.Breaking Change Previously
onChangewould be called with the value directly. Now it gets called with an event containing the value. This was done to be in line with how the other inputs work.