Redo DateInput using downshift #281
Conversation
dferber90
force-pushed
the
df-redo-date-input-using-downshift
branch
from
df503d4 to
5d790e5
Compare
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import requiredIf from 'react-required-if'; | ||
| import Downshift from 'downshift'; |
There was a problem hiding this comment.
Note that we're not importing moment into this component at all. All usage of moment is moved to the utils. This allows to use the date-input (and the other ones) with any date-library (like date-fns).
| } | ||
|
|
||
| .year > * { | ||
| margin: 0 0 0 4px; |
There was a problem hiding this comment.
I am such a party pooper! Why not 6px?
There was a problem hiding this comment.
Both 4px and 6px are part of our design system. Why would you prefer 6px?
|
|
||
| .menu { | ||
| composes: menuBase; | ||
| padding-bottom: 10px; |
There was a problem hiding this comment.
Is this a sum of 4 and 6 on the .container? Should we have variables and a calc here?
There was a problem hiding this comment.
It's not the sum of anything to my knowledge. We don't need to have a design token for everything, it's okay if edge-cases use their own values. A date-calendar is a one-off component imho. There is no token for a spacing of 10 either, so I hardcoded it.
dferber90
force-pushed
the
df-redo-date-input-using-downshift
branch
from
fa849a1 to
9ebae36
Compare
dferber90
force-pushed
the
df-redo-date-input-using-downshift
branch
from
3ac9eb3 to
2932680
Compare
This is the new
DateInputbased ondownshift.I will add follow-up PRs to replace
DateTimeInputand to addDateRangeInputbased on this one.Breaking Change Previously
onChangewould be called with the value directly. Now it gets called with an event containing the value. This was done to be in line with how the other inputs work.