Restore 1.9 compat, drop 1.8 compat #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.8 compat, while it was intended to be, was broken for a possibly very long time.
The reason being, the CI matrix as introduced in 1016f61 was broken: CircleCI set
VERSION
, while the Makefile expectedCLOJURE_VERSION
.So, surely, progressively factual support degraded.
This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.
I deem 1.8 not worth fixing, given that:
Unable to resolve var: *print-namespace-maps* in this context, compiling:(leiningen/core/main.clj:342:5)
while running thecider-nrepl.plugin-test
.