Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 1.9 compat, drop 1.8 compat #840

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Restore 1.9 compat, drop 1.8 compat #840

merged 1 commit into from
Jan 9, 2024

Conversation

vemv
Copy link
Member

@vemv vemv commented Jan 5, 2024

Closes #836

1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61 was broken: CircleCI set VERSION, while the Makefile expected CLOJURE_VERSION.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

I deem 1.8 not worth fixing, given that:

  • it was broken already;
  • nobody complained;
  • we planned to drop it; and most importantly
  • it was hard to restore, since it would mean running an older Leiningen (Lein has used 1.9+ features for over 5 years, which means that the CCI images would have to be replaced with something else)
    • In particular, I was hitting Unable to resolve var: *print-namespace-maps* in this context, compiling:(leiningen/core/main.clj:342:5) while running the cider-nrepl.plugin-test.

1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61
was broken: CircleCI set `VERSION`, while the Makefile expected `CLOJURE_VERSION`.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

Closes #836
@vemv vemv requested a review from bbatsov January 5, 2024 15:22
@bbatsov bbatsov merged commit 8913742 into master Jan 9, 2024
@bbatsov bbatsov deleted the 836--ci branch January 9, 2024 09:14
@bbatsov
Copy link
Member

bbatsov commented Jan 9, 2024

nobody complained;

Can't argue with this argument. 😆 Thanks for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI matrix doesn't hit clojures other than 1.11
2 participants