Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI matrix doesn't hit clojures other than 1.11 #836

Closed
vemv opened this issue Nov 28, 2023 · 0 comments · Fixed by #840
Closed

CI matrix doesn't hit clojures other than 1.11 #836

vemv opened this issue Nov 28, 2023 · 0 comments · Fixed by #840
Assignees
@vemv

Comments

@vemv
Copy link
Member

vemv commented Nov 28, 2023

In Circle we set VERSION, which our makefile expects as CLOJURE_VERSION 😬
@vemv vemv self-assigned this Nov 28, 2023
@vemv vemv mentioned this issue Nov 30, 2023
Closed
vemv added a commit that referenced this issue Jan 5, 2024
@vemv
Restore 1.9 compat, drop 1.8 compat
c473d7d 
1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61
was broken: CircleCI set `VERSION`, while the Makefile expected `CLOJURE_VERSION`.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

Closes #836
vemv added a commit that referenced this issue Jan 5, 2024
@vemv
Restore 1.9 compat, drop 1.8 compat
31963e2 
1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61
was broken: CircleCI set `VERSION`, while the Makefile expected `CLOJURE_VERSION`.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

Closes #836
@vemv vemv mentioned this issue Jan 5, 2024
Merged
bbatsov pushed a commit that referenced this issue Jan 9, 2024
@vemv @bbatsov
Restore 1.9 compat, drop 1.8 compat
8913742 
1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61
was broken: CircleCI set `VERSION`, while the Makefile expected `CLOJURE_VERSION`.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

Closes #836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vemv vemv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore 1.9 compat, drop 1.8 compat clojure-emacs/cider-nrepl
1 participant
@vemv