Fix CI on master #2193
Merged
Fix CI on master #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bfops
reviewed
Jan 30, 2025
bfops
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
No blocking concerns left for me!
I think we should test the artifacts on MacOS + Windows to make sure they still work, but since they're currently broken, this PR definitely can't make things worse.
Windows link: https://spacetimedb-client-binaries.nyc3.digitaloceanspaces.com/noa/fix-master-ci/spacetime-x86_64-pc-windows-msvc.zip
Apple amd64: https://spacetimedb-client-binaries.nyc3.digitaloceanspaces.com/noa/fix-master-ci/spacetime-x86_64-apple-darwin.tar.gz
Apple arm64: https://spacetimedb-client-binaries.nyc3.digitaloceanspaces.com/noa/fix-master-ci/spacetime-aarch64-apple-darwin.tar.gz
(The Linux one seems to work for me, I un-tard and ran a trivial command on each of the binaries).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Follow up to #2011, fixes #2159. I merged the different packaging jobs into a matrix, since it seems like they were all copy/pasted anyway and it makes it easier to make sure that the packaging process is consistent. I also tweaked the names of the artifacts, as I was talking about in #2126 (cc @clockworklabs/devops); they're now
spacetime-$LLVM_TARGET_TRIPLE.$EXE_OR_TARGZ. I didn't maintain thecp --sparse=neverthing from #544, since it seems like the tar crate now supports sparse archives.Expected complexity level and risk
2
Testing
noa/fix-master-cifor a tag name, but that obviously won't be an issue on master.