-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish spacetimedb-update functionality #2126
Conversation
621fba2
to
59ec2a0
Compare
(It looks like this currently isn't passing CI, so I'm holding off on review) |
59ec2a0
to
35e5488
Compare
Review notes:
|
Note to self: I still need to:
|
35e5488
to
030c9b3
Compare
I removed the rm-core-as-dep-of-cli commit from this branch, I'll do it as a follow-up PR. |
030c9b3
to
80940cc
Compare
(I merged in |
05186de
to
7f72ea7
Compare
7f72ea7
to
e296ddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the conversation elsewhere today, I'm approving this as-is. If we need to do further testing, changes, or code cleanups, we will have to do them in followup PRs. For now let's merge this and start getting it tested more widely.
(That said, CI seems to be failing) |
e296ddb
to
d6c9122
Compare
d6c9122
to
68f3581
Compare
Description of Changes
based off #2011
Adds implementations to all the subcommands of
spacetime version
.Expected github release artifact structure:
spacetime-{rustc-target-triple}.{ext}
ext = if windows { "zip" } else { "tar.gz" }
spacetimedb-cli[.exe]
,spacetimedb-standalone[.exe]
,spacetimedb-update[.exe]
cc @clockworklabs/devops - feedback on this^^ would be nice. I kept the edge cases since that's how it already was and I figured that might make it easier in the release workflow, but honestly I'd prefer if it was justImplemented in #2193.spacetime-{rustc-target-triple}.{ext}
if possible. Not sure where the release flow is or if it's even automated.Expected complexity level and risk
3 - a complex bit of code that's implementing a theoretically perpetual contract between
spacetimedb-update
, github release artifacts, and the directory structure.Testing
spacetime version install
works