NFC: enforce style for C# locally and on CI #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
bfops
added
no runtime change
kazimuth
reviewed
Aug 13, 2024
kazimuth
reviewed
Aug 13, 2024
bfops
reviewed
Aug 13, 2024
| @@ -176,7 +176,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context) | |||
| transform: (context, ct) => | |||
| { | |||
| var tableSyntax = (TypeDeclarationSyntax)context.TargetNode; | |||
| var table = context.SemanticModel.GetDeclaredSymbol(tableSyntax)!; | |||
| var table = context.SemanticModel.GetDeclaredSymbol(tableSyntax, ct)!; | |||
There was a problem hiding this comment.
this looks like an actual runtime change, yes? Why is that?
There was a problem hiding this comment.
(I removed the no-runtime-change label)
There was a problem hiding this comment.
Well as it's purely codegen, technically it's still compile-time change, and one that shouldn't matter at that... but I don't have a strong opinion on that.
bfops
removed
the
no runtime change
RReverser
force-pushed
the
ingvar/csharp-format-ci
branch
from
b4e03c5 to
d660a04
Compare
bfops
approved these changes
Aug 21, 2024
Unlike `dotnet` CLI, it doesn't like folder path and needs an explicit wildcard instead.
RReverser
force-pushed
the
ingvar/csharp-format-ci
branch
from
d660a04 to
66fe192
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As suggested in the other PR, adds C# style checks to the CI so that minor issues and reformatting are fixed early.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!