Add support for I256 and U256
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/256
branch
7 times, most recently
from
7806859 to
810a8d2
Compare
lcodes
approved these changes
Jul 5, 2024
bfops
added
abi-break
Centril
changed the title
I256 and U256I256 and U256
RReverser
reviewed
Aug 6, 2024
RReverser
reviewed
Aug 6, 2024
RReverser
reviewed
Aug 6, 2024
RReverser
reviewed
Aug 6, 2024
RReverser
reviewed
Aug 6, 2024
RReverser
reviewed
Aug 6, 2024
Centril
force-pushed
the
centril/256
branch
2 times, most recently
from
728dab8 to
2563697
Compare
RReverser
reviewed
Aug 6, 2024
Centril
force-pushed
the
centril/256
branch
8 times, most recently
from
c41b116 to
c465d56
Compare
RReverser
reviewed
Aug 8, 2024
RReverser
reviewed
Aug 8, 2024
RReverser
reviewed
Aug 8, 2024
Centril
force-pushed
the
centril/256
branch
2 times, most recently
from
662248d to
e282924
Compare
lcodes
reviewed
Aug 8, 2024
lcodes
reviewed
Aug 8, 2024
lcodes
reviewed
Aug 8, 2024
lcodes
reviewed
Aug 8, 2024
| @@ -175,7 +175,7 @@ public void Write(BinaryWriter writer, Inner? value) | |||
| new AlgebraicType.U64(default); | |||
| } | |||
|
|
|||
| public readonly struct U128 : IReadWrite<SpacetimeDB.U128> | |||
| public readonly struct U128Stdb : IReadWrite<SpacetimeDB.U128> | |||
There was a problem hiding this comment.
Why not call this one U128 and the other UInt128?
Or make both explicit by naming the other U128Sys?
There was a problem hiding this comment.
Why not call this one U128 and the other UInt128?
This seemed to me the right way, but when I tried it, C# was unhappy about Int128 not having dibs on SpacetimedB.BSATN.I128.
lcodes
approved these changes
Aug 8, 2024
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Aug 13, 2024
## Description of Changes These types have been moved to the main repo, where they are used by bindings-csharp as well. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1477 --------- Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
bfops
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Aug 29, 2024
## Description of Changes These types have been moved to the main repo, where they are used by bindings-csharp as well. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1477 --------- Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
lcodes
pushed a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Sep 29, 2024
## Description of Changes These types have been moved to the main repo, where they are used by bindings-csharp as well. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1477 --------- Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #1097.
Implements support for
256-width integers in SATS and friends.The integer types are backed by the crate
ethnumwhich provides support as-if they were primitive Rust types.API and ABI breaking changes
Breaks the BSATN-encoding of
AlgebraicType.Expected complexity level and risk
2 -- some subtle considerations:
u128::MAXfor e.g.,u256)Testing
Unit tests and SDK tests have been amended.