Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize macro crate #1406

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Reorganize macro crate #1406

merged 4 commits into from
Oct 23, 2024

Conversation

coolreader18
Copy link
Collaborator

Description of Changes

Follow-up to #1314

Expected complexity level and risk

1

@coolreader18 coolreader18 mentioned this pull request Jun 12, 2024
@coolreader18 coolreader18 force-pushed the noa/macro-reorg branch 2 times, most recently from cc73023 to 11aea35 Compare June 12, 2024 19:03
@Centril Centril changed the base branch from master to noa/macro-rework June 13, 2024 09:32
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Here are some suggestions for further reorganization that could be done in more PRs.

@coolreader18 coolreader18 force-pushed the noa/macro-rework branch 2 times, most recently from c0aee9c to e7ddac4 Compare July 3, 2024 20:42
@Centril Centril force-pushed the noa/macro-rework branch 2 times, most recently from 30bdb2c to a7876e2 Compare July 4, 2024 15:17
@coolreader18 coolreader18 force-pushed the noa/macro-rework branch 5 times, most recently from 72a0243 to 4071a5b Compare September 9, 2024 20:45
Base automatically changed from noa/macro-rework to master September 10, 2024 15:45
@coolreader18 coolreader18 force-pushed the noa/macro-reorg branch 2 times, most recently from 9d5f08f to bee4aee Compare October 8, 2024 21:40
@coolreader18 coolreader18 marked this pull request as ready for review October 8, 2024 21:40
@coolreader18 coolreader18 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 2d8224a Oct 23, 2024
7 of 8 checks passed
@coolreader18 coolreader18 deleted the noa/macro-reorg branch October 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants