Impl macro rework #1314
Merged
Impl macro rework #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
May 30, 2024
cloutiertyler
added
Do not merge
coolreader18
force-pushed
the
noa/macro-rework
branch
2 times, most recently
from
41c4d18 to
972a7f8
Compare
Centril
requested changes
Jun 11, 2024
crates/bindings-macro/src/lib.rs
Outdated
Comment on lines
820
to
949
| macro_rules! special_reducer { | ||
| ($(#[$attr:meta])* $name:ident = $reducer_name:literal) => { | ||
| #[proc_macro_attribute] | ||
| pub fn $name(args: StdTokenStream, item: StdTokenStream) -> StdTokenStream { | ||
| cvt_attr(args, item, quote!(), |args, original_function: ItemFn| { | ||
| syn::parse2::<Nothing>(args)?; | ||
| gen_reducer(original_function, $reducer_name, ReducerExtra::None) | ||
| }) | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| if std::env::var("PROC_MACRO_DEBUG").is_ok() { | ||
| { | ||
| #![allow(clippy::disallowed_macros)] | ||
| println!("{}", output); | ||
| } | ||
| } | ||
| special_reducer!( | ||
| // TODO: doc | ||
| init = "__init__" | ||
| ); | ||
|
|
||
| Ok(output) | ||
| } | ||
| special_reducer!( | ||
| // TODO: doc | ||
| connect = "__identity_connected__" | ||
| ); | ||
|
|
||
| fn spacetimedb_special_reducer(name: &str, item: TokenStream) -> syn::Result<TokenStream> { | ||
| let original_function = syn::parse2::<ItemFn>(item)?; | ||
| gen_reducer(original_function, name, ReducerExtra::None) | ||
| } | ||
| special_reducer!( | ||
| // TODO: doc | ||
| disconnect = "__identity_disconnected__" | ||
| ); | ||
|
|
||
| special_reducer!( | ||
| // TODO: doc | ||
| update = "__update__" | ||
| ); |
There was a problem hiding this comment.
I found myself jumping back and forth between fn reducer and these, so please move these definitions after fn reducer. :)
There was a problem hiding this comment.
I have a follow up PR that reorganizes the module structure - that'll make it much less confusing.
There was a problem hiding this comment.
Happy to review that PR :)
coolreader18
force-pushed
the
noa/macro-rework
branch
from
d678b83 to
9fa81ef
Compare
Merged
coolreader18
force-pushed
the
noa/macro-rework
branch
2 times, most recently
from
2de1f2f to
7606ffa
Compare
Centril
approved these changes
Jun 13, 2024
coolreader18
force-pushed
the
noa/macro-rework
branch
from
7606ffa to
b8d3e77
Compare
coolreader18
force-pushed
the
noa/macro-rework
branch
2 times, most recently
from
c0aee9c to
e7ddac4
Compare
Centril
force-pushed
the
noa/macro-rework
branch
3 times, most recently
from
30bdb2c to
a7876e2
Compare
RReverser
reviewed
Aug 26, 2024
| @@ -225,7 +225,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context) | |||
|
|
|||
| public void Insert() {{ | |||
| var bytes = SpacetimeDB.Runtime.Insert(tableId.Value, this); | |||
| // bytes should contain modified value now with autoinc fields updated | |||
| // bytes should contain modified value now with auto_inc fields updated | |||
There was a problem hiding this comment.
Is this a search-replace change? Probably shouldn't be necessary here and in the snapshots.
Merged
coolreader18
force-pushed
the
noa/macro-rework
branch
from
a7876e2 to
bfb0832
Compare
coolreader18
force-pushed
the
noa/macro-rework
branch
2 times, most recently
from
dd4123d to
2f53410
Compare
coolreader18
force-pushed
the
noa/macro-rework
branch
from
2f53410 to
72a0243
Compare
coolreader18
force-pushed
the
noa/macro-rework
branch
from
72a0243 to
4071a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
Expected complexity level and risk
2