Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify the part hash during mempool recovery #1670

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Mar 12, 2025

Description

Closes #1667

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

Sorry, something went wrong.

@rach-id rach-id self-assigned this Mar 12, 2025
@rach-id rach-id requested a review from a team as a code owner March 12, 2025 10:13
@rach-id rach-id requested review from rootulp and ninabarbakadze and removed request for a team March 12, 2025 10:13
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo!! this is actually a huge savings as we can get rid of the proofs (and inner roots) in the have messages since we're already verifying them here.

could do as a followup

@evan-forbes evan-forbes merged commit 187e638 into feature/recovery Mar 12, 2025
22 of 24 checks passed
@evan-forbes evan-forbes deleted the rachid/recovered-parts-verification branch March 12, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants