Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the parts hash when recovering them from the mempool #1667

Closed
rach-id opened this issue Mar 11, 2025 · 1 comment
Closed

Verify the parts hash when recovering them from the mempool #1667

rach-id opened this issue Mar 11, 2025 · 1 comment
Assignees
@rach-id
Labels
block prop recovery

Comments

@rach-id
Copy link
Member

rach-id commented Mar 11, 2025

After implementing #1661, we should stick the block parts hashes in the compact block. This would allow validating that the recovered parts are valid. Otherwise, an invalid hash can fail the block construction without having any apparent reason for it.
@rach-id rach-id self-assigned this Mar 11, 2025
@rach-id rach-id mentioned this issue Mar 12, 2025
Merged
3 tasks
evan-forbes pushed a commit that referenced this issue Mar 12, 2025
@rach-id
feat: verify the part hash during mempool recovery (#1670)

Verified

This commit was signed with the committer’s verified signature.
gamalielhere Gamaliel 'Yel' Padillo
GPG key ID: 573746C9C3620E60
Verified
Learn about vigilant mode
Loading
Loading status checks…
187e638 
## Description

Closes #1667

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
@rach-id
Copy link
Member Author

rach-id commented Mar 16, 2025

done in #1670

@rach-id rach-id closed this as completed Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
block prop recovery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id