feat: re-add ability to filter tables from trace data #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `S3Download` implementation to allow specifying the names of the traced tables when downloading from an S3 bucket. This enhancement enables file filtering and reduces the amount of data downloaded. It is a desirable feature when interacting with the traced data of large network tests. If no table name is provided, then `S3Download` downloads all the traced tables.
cmwaters
requested review from
staheri14 and
evan-forbes
and removed request for
a team
rootulp
approved these changes
Aug 13, 2024
| @@ -23,6 +23,8 @@ import ( | |||
| "github.com/aws/aws-sdk-go/service/s3" | |||
| ) | |||
|
|
|||
| const jsonL = ".jsonl" | |||
evan-forbes
approved these changes
Aug 13, 2024
rach-id
pushed a commit
that referenced
this pull request
Nov 18, 2024
Reintroduces #1374 in a non-breaking way. This would be helpful for my compact blocks test. I don't know why it got reverted --------- Co-authored-by: Sanaz Taheri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces #1374 in a non-breaking way. This would be helpful for my compact blocks test. I don't know why it got reverted